linux-kernel - Re: [PATCH perf/core v9 01/16] perf-symbol: Introduce filename_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160531145440.70aebd1e8a2529f742978a6b@kernel.org>
Date:	Tue, 31 May 2016 14:54:40 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>
Subject: Re: [PATCH perf/core v9 01/16] perf-symbol: Introduce
 filename__readable to check readability

On Mon, 30 May 2016 13:04:47 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> Em Mon, May 30, 2016 at 01:03:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sun, May 29, 2016 at 12:15:13AM +0900, Masami Hiramatsu escreveu:
> > > Introduce filename__readable to check readability by opening
> > > the file directly. Since the access(R_OK) just checks the
> > > readability based on real UID/GID, it is ignored that the
> > > effective UID/GID and capabilities for some special file (e.g.
> > > /proc/kcore).
> > > filename__readable() directly opens given file with O_RDONLY
> > > so that the kernel checks it by effective UID/GID and capabilities.
> > 
> > 
> > You missed the Signed-off-by line.
> 
> This this for you this time, no need to resend.

Oops, and thanks!!

> 
> - Arnaldo


-- 
Masami Hiramatsu <mhiramat@...nel.org>