linux-kernel - Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <574DA107.8050002@samsung.com>
Date:	Tue, 31 May 2016 16:34:47 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Russell King - ARM Linux <linux@...linux.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	Tobias Klauser <tklauser@...tanz.ch>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Sylvain Lemieux <slemieux.tyco@...il.com>,
	Andy Gross <andy.gross@...aro.org>,
	David Brown <david.brown@...aro.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Barry Song <baohua@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Tony Prisk <linux@...sktech.co.nz>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	nios2-dev@...ts.rocketboards.org,
	adi-buildroot-devel@...ts.sourceforge.net,
	linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, sparclinux@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch

On 05/31/2016 04:21 PM, Russell King - ARM Linux wrote:
> On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote:
>> Remove __init annotation from all of console->setup implementations
>> because:
>> 1. The pointer to it is stored in a struct console which is not
>>    marked with __initdata.
>> 2. It is referenced by register_console() from kernel which is not
>>    marked with __init.
> 
> However, many of these drivers, the console can only be used when the
> driver is built-in, and register_console() is only called early in
> initialisation.

Indeed so maybe the word "fix" in commit subject is not proper because
there might be no error at all. My point is that current solution is a
little bit non-obvious and an error might happen. If we were sure that
register_console() is called only from other __init functions, then it
should be made also __init.

Best regards,
Krzysztof