linux-kernel - RE: mwifiex: fix self-assignment in mwifiex_uap_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <800a757581ef4513836789365436e621@SC-EXCH04.marvell.com>
Date:	Tue, 31 May 2016 15:23:08 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	Dave Jones <davej@...emonkey.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
CC:	Xinming Hu <huxm@...vell.com>, Cathy Luo <cluo@...vell.com>,
	Kalle Valo <kvalo@...eaurora.org>
Subject: RE: mwifiex: fix self-assignment in mwifiex_uap_recv_packet

Hi Dave,

> From: Dave Jones [mailto:davej@...emonkey.org.uk]
> Sent: Tuesday, May 31, 2016 8:47 PM
> To: Linux Kernel
> Cc: Xinming Hu; Cathy Luo; Amitkumar Karwar; Kalle Valo
> Subject: mwifiex: fix self-assignment in mwifiex_uap_recv_packet
> 
> This function wants to operate on the adapter pointer in the priv
> struct, not on itself which makes no sense.
> 
> Signed-off-by: Dave Jones <davej@...emonkey.org.uk>
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> index 666e91af59d7..bf5660eb27d3 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> @@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct
> mwifiex_private *priv,  int mwifiex_uap_recv_packet(struct
> mwifiex_private *priv,
>  			    struct sk_buff *skb)
>  {
> -	struct mwifiex_adapter *adapter = adapter;
> +	struct mwifiex_adapter *adapter = priv->adapter;
>  	struct mwifiex_sta_node *src_node;
>  	struct ethhdr *p_ethhdr;
>  	struct sk_buff *skb_uap;

Thanks for the patch. This has been already taken cared by below patch submitted recently.
https://patchwork.kernel.org/patch/9115501/

Regards,
Amitkumar