linux-kernel - Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160531174748.GI26768@pengutronix.de>
Date:	Tue, 31 May 2016 19:47:48 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	"George G. Davis" <george_davis@...tor.com>
Cc:	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, netdev@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>,
	Alexandre Courbot <gnurou@...il.com>,
	Fugang Duan <fugang.duan@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Linus Walleij <linus.walleij@...aro.org>,
	Russell King <linux@...linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API

Hello George,

On Tue, May 31, 2016 at 01:17:51PM -0400, George G. Davis wrote:
> Convert the i.MX FEC driver and DT files to use the GPIOD API
> which automatically handles GPIO polarity.

additionally to what Fabio said, there is also a nicer approach in the
making. The resulting dts would look as follows:

	&fec {
		phy-handle = <&ethphy>;
		...

		mdio {
			#address-cells = <1>;
			#size-cells = <0>;

			ethphy: ethernet-phy@7 {
				...

				reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
			};
		};
	};

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |