linux-kernel - Re: [PATCHv5] support for AD5820 camera auto-focus coil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jun 2016 00:22:22 +0300
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Pavel Machek <pavel@....cz>
Cc:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	pali.rohar@...il.com, sre@...nel.org,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
	aaro.koskinen@....fi, patrikbachan@...il.com, serge@...lyn.com,
	linux-media@...r.kernel.org, mchehab@....samsung.com
Subject: Re: [PATCHv5] support for AD5820 camera auto-focus coil

Hi Pavel,

On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote:
> 
> This adds support for AD5820 autofocus coil, found for example in
> Nokia N900 smartphone.
> 
> Signed-off-by: Pavel Machek <pavel@....cz>

The patch looks good to me but then I came to think of a question I've
missed so far: is there DT documentation somewhere for the properties used
by the driver? I might put that to a separate patch, and cc the relevant
list.

Whether we decide to have the module in DT or not is orthogonal to this.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk