[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160531212517.GA26582@redhat.com>
Date: Tue, 31 May 2016 23:25:17 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Michal Hocko <mhocko@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
LKML <linux-kernel@...r.kernel.org>,
Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper
On 05/31, Michal Hocko wrote:
>
> @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk)
> * If the task is exiting make sure the whole thread group
> * is exiting and cannot acces mm anymore.
> */
> - spin_lock_irq(&p->sighand->siglock);
> - exiting = signal_group_exit(p->signal);
> - spin_unlock_irq(&p->sighand->siglock);
> - if (exiting)
> + if (signal_group_exit(p->signal))
> continue;
Yes, thanks Michal. signal_group_exit() is not really right too (coredump)
but this is not that important and you are going to rework this code anyway.
Oleg.
Powered by blists - more mailing lists