linux-kernel - RE: [PATCH] mmc: host: use pr_err for sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CC22646CC0522A488A20F7A66BFD619308D8DB@irsmsx105.ger.corp.intel.com>
Date:	Wed, 1 Jun 2016 05:12:59 +0000
From:	"Baranowska, BeataX" <beatax.baranowska@...el.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	"Hunter, Adrian" <adrian.hunter@...el.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Dong, Chuanxiao" <chuanxiao.dong@...el.com>,
	"Jarosz, SebastianX" <sebastianx.jarosz@...el.com>
Subject: RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Tuesday, May 31, 2016 5:47 PM
> To: Baranowska, BeataX <beatax.baranowska@...el.com>
> Cc: Hunter, Adrian <adrian.hunter@...el.com>; Ulf Hansson
> <ulf.hansson@...aro.org>; linux-mmc@...r.kernel.org; linux-
> kernel@...r.kernel.org; Dong, Chuanxiao <chuanxiao.dong@...el.com>;
> Jarosz, SebastianX <sebastianx.jarosz@...el.com>
> Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
> 
> On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
> <beatax.baranowska@...el.com> wrote:
> > From: Chuanxiao Dong <chuanxiao.dong@...el.com>
> >
> > sdhci_dumpregs is used to dump registers when error happens. Thus it
> > should use pr_err instead of pr_debug to show more information about
> the hardware.
> >
> 
> Wouldn't be too noisy?
> 
> --
> With Best Regards,
> Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska