linux-kernel - Re: [PATCH] ASoC: hdmi-codec: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574E818A.4000708@ti.com>
Date:	Wed, 1 Jun 2016 09:32:42 +0300
From:	Jyri Sarha <jsarha@...com>
To:	Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>
CC:	Arnaud Pouliquen <arnaud.pouliquen@...com>,
	PC Liao <pc.liao@...iatek.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI

On 06/01/16 00:12, Arnd Bergmann wrote:
> SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading
> to a link error:
> 
> In function `hdmi_codec_hw_params':
> sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init'
> sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init'
> 
> This changes the Kconfig file to select HDMI, as the other codec using
> hdmi_audio_infoframe_init already does.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 09184118a8ab ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")

Oops. I wonder how I missed that. Something in omap2plus_defconfig must
trigger the selecting of HDMI.

Acked-by: Jyri Sarha <jsarha@...com>


> ---
>  sound/soc/codecs/Kconfig | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 4d82a58ff6b0..f3fb98f0a995 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -483,9 +483,10 @@ config SND_SOC_DMIC
>  	tristate
>  
>  config SND_SOC_HDMI_CODEC
> -       tristate
> -       select SND_PCM_ELD
> -       select SND_PCM_IEC958
> +	tristate
> +	select SND_PCM_ELD
> +	select SND_PCM_IEC958
> +	select HDMI
>  
>  config SND_SOC_ES8328
>  	tristate "Everest Semi ES8328 CODEC"
>