linux-kernel - Re: [PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1606010844160.3629@nanos>
Date:	Wed, 1 Jun 2016 08:45:25 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	David Kershner <david.kershner@...sys.com>
cc:	corbet@....net, mingo@...hat.com, hpa@...or.com,
	gregkh@...uxfoundation.org, erik.arfvidson@...sys.com,
	timothy.sell@...sys.com, hofrat@...dl.org, dzickus@...hat.com,
	jes.sorensen@...hat.com, alexander.curtin@...sys.com,
	janani.rvchndrn@...il.com, sudipm.mukherjee@...il.com,
	prarit@...hat.com, david.binder@...sys.com, nhorman@...hat.com,
	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, driverdev-devel@...uxdriverproject.org,
	sparmaintainer@...sys.com,
	Bryan Thompson <bryan.thompson@...sys.com>
Subject: Re: [PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback_lock
 a mutex

On Tue, 31 May 2016, David Kershner wrote:

> From: Bryan Thompson <bryan.thompson@...sys.com>
> 
> visordriver_callback_lock is just a binary semaphore that logically
> makes more sense as a mutex.
> 
> Signed-off-by: Bryan Thompson <bryan.thompson@...sys.com>
> Signed-off-by: David Kershner <david.kershner@...sys.com>
> Reviewed-by: Tim Sell <Timothy.Sell@...sys.com>
> ---
>  drivers/staging/unisys/include/visorbus.h       |  3 ++-
>  drivers/staging/unisys/visorbus/visorbus_main.c | 10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h
> index 9bb88bb..9da25c0 100644
> --- a/drivers/staging/unisys/include/visorbus.h
> +++ b/drivers/staging/unisys/include/visorbus.h
> @@ -161,7 +161,8 @@ struct visor_device {
>  	struct timer_list timer;
>  	bool timer_active;
>  	bool being_removed;
> -	struct semaphore visordriver_callback_lock;
> +	/* mutex to serialize visor_driver function callbacks */

TBH. I hate these kind of comments. The mutex name is self explaining, right?
I rather wish you would have spent time documenting the non obvious parts of
the code.

Thanks,

	tglx