linux-kernel - Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574E95B6.801@baylibre.com>
Date:	Wed, 1 Jun 2016 09:58:46 +0200
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	daniel.lezcano@...aro.org, Ma Haijun <mahaijuns@...il.com>
Subject: Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer

On 06/01/2016 09:03 AM, Thomas Gleixner wrote:
> On Tue, 31 May 2016, Neil Armstrong wrote:
>> +static int oxnas_rps_timer_shutdown(struct clock_event_device *evt)
>> +{
>> +	struct oxnas_rps_timer *rps =
>> +		container_of(evt, struct oxnas_rps_timer, clkevent);
>> +
>> +	if (!clockevent_state_periodic(evt))
>> +		return 0;
> 
> So if the timer is in oneshot mode, then you just leave it enabled. What's the
> rationale of this?

Indeed, there is no rationale.
Fixed in v2.

>> +
>> +	oxnas_rps_timer_config(rps, 0, 0);
> 
> Thanks,
> 
> 	tglx
> 

Thanks,
Neil