linux-kernel - Re: [PATCH v2 2/8] zram: switch to crypto compress API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160601011706.GD461@swordfish>
Date:	Wed, 1 Jun 2016 10:17:06 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH v2 2/8] zram: switch to crypto compress API

On (06/01/16 08:44), Minchan Kim wrote:
> <snip>
>   
> trivial:
> 
> One thing I got missed in review.
> 
> > -int zcomp_compress(struct zcomp *comp, struct zcomp_strm *zstrm,
> > -		const unsigned char *src, size_t *dst_len);
> > +int zcomp_compress(struct zcomp_strm *zstrm,
> > +		const unsigned char *src, unsigned int *dst_len);
> 
> unsigned int for dst_len
> 
> >  
> > -int zcomp_decompress(struct zcomp *comp, const unsigned char *src,
> > +int zcomp_decompress(struct zcomp_strm *zstrm,
> > +		const unsigned char *src,
> >  		size_t src_len, unsigned char *dst);
> >  
> 
> size_t src_len?

thanks for spotting it!

	-ss