linux-kernel - [PATCH] fbdev: pxafb: clampval() doesn't update the variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed,  1 Jun 2016 14:07:50 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	tomi.valkeinen@...com
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fbdev: pxafb: clampval() doesn't update the variable

clampval() returns the clamped value instead of updating the variable
itself. And the driver is using it in a wrong way. Fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
---
 drivers/video/fbdev/pxafb.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 2c0487f4f805..b1197980b9b1 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -417,12 +417,12 @@ static int pxafb_adjust_timing(struct pxafb_info *fbi,
 	var->yres = max_t(int, var->yres, MIN_YRES);
 
 	if (!(fbi->lccr0 & LCCR0_LCDT)) {
-		clamp_val(var->hsync_len, 1, 64);
-		clamp_val(var->vsync_len, 1, 64);
-		clamp_val(var->left_margin,  1, 255);
-		clamp_val(var->right_margin, 1, 255);
-		clamp_val(var->upper_margin, 1, 255);
-		clamp_val(var->lower_margin, 1, 255);
+		var->hsync_len = clamp_val(var->hsync_len, 1, 64);
+		var->vsync_len = clamp_val(var->vsync_len, 1, 64);
+		var->left_margin = clamp_val(var->left_margin,  1, 255);
+		var->right_margin = clamp_val(var->right_margin, 1, 255);
+		var->upper_margin = clamp_val(var->upper_margin, 1, 255);
+		var->lower_margin = clamp_val(var->lower_margin, 1, 255);
 	}
 
 	/* make sure each line is aligned on word boundary */
-- 
2.7.1.410.g6faf27b