linux-kernel - Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574EAAD7.2010706@mev.co.uk>
Date:	Wed, 1 Jun 2016 10:28:55 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Joe Perches <joe@...ches.com>,
	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

On 31/05/16 18:07, Joe Perches wrote:
> On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote:
>> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
>>>
>>> This is a patch to the s626.c file that fixes up a type issues like
>>> i.e Prefer kernel type 'u8' over 'uint8_t'
>>>       Prefer kernel type 'u16' over 'uint16_t'
>>>       Prefer kernel type 'u32' over 'uint32_t'
>>>       Prefer kernel type 's16' over 'int16_t'
>>>       Prefer kernel type 's32' over 'int32_t'
>>> found by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Ravishankar Karkala Mallikarjunayya
>>> ---
>>> changes since v1: Rework
>>> ---
>>>    drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++-----------------
>>>    1 file changed, 106 insertions(+), 106 deletions(-)
>>>
>> Thanks.  It would have been nice if the checkpatch.pl tool detected
>> _all_ the instances of these types.  As a result of this patch, s626.c
>> contains a mixture of the different integer type styles.  I guess we can
>> fix that up later though.
>
> Seems trivial enough to do.
>
> There was a possible issue with converting int_t types that
> were used as uapi function arguments.
>
> checkpatch currently warns only about variable declarations and
> not function declarations.  It doesn't convert casts either.

Oh right, I wasn't sure what the pattern was.  It does warn about int_t 
types in _some_function declarations, but on closer inspection, it only 
seems to do so when there is a line break before the parameter 
declaration.  For example:

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#519: FILE: drivers/staging/comedi/drivers/s626.c:519:
+			uint16_t chan, int16_t dacdata)


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-