lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jun 2016 10:35:57 +0100 From: Ian Abbott <abbotti@....co.uk> To: Ashwin Ravichandran <ashwinravichandran24@...il.com>, gregkh@...uxfoundation.org Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, hsweeten@...ionengravers.com Subject: Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue On 01/06/16 10:19, Ashwin Ravichandran wrote: > Fixed a coding style issue. > > Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@...il.com> > --- > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- > drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > index 3757074..9c27999 100644 > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev, > data[0] != ADDIDATA_TIMER) > return -EINVAL; > > - devpriv->tsk_Current = current; > + devpriv->tsk_current = current; > > devpriv->timer_mode = data[0]; > > diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c > index 40ff914..b2f6712 100644 > --- a/drivers/staging/comedi/drivers/addi_apci_3501.c > +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c > @@ -68,7 +68,7 @@ > struct apci3501_private { > unsigned long amcc; > unsigned long tcw; > - struct task_struct *tsk_Current; > + struct task_struct *tsk_current; > unsigned char timer_mode; > }; > > @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d) > } > > /* Enable Interrupt Send a signal to from kernel to user space */ > - send_sig(SIGIO, devpriv->tsk_Current, 0); > + send_sig(SIGIO, devpriv->tsk_current, 0); > ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG); > ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG | > ADDI_TCW_CTRL_IRQ_ENA); > The patch looks fine (although this odd-ball Comedi driver shouldn't really be sending signals to a user-space task!). Is this really PATCH 2649/2649? Reviewed-by: Ian Abbott <abbotti@....co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
Powered by blists - more mailing lists