linux-kernel - RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jun 2016 10:01:01 +0000
From:	Dexuan Cui <decui@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	KY Srinivasan <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"rolf.neugebauer@...ker.com" <rolf.neugebauer@...ker.com>,
	"dave.scott@...ker.com" <dave.scott@...ker.com>,
	"ian.campbell@...ker.com" <ian.campbell@...ker.com>
Subject: RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying &
 updating the percpu list

> >> [    5.472143] BUG: unable to handle kernel paging request at
> >> 000000079fff5288
> >> [    5.477107] IP: [<ffffffffa0004b91>] vmbus_onoffer+0x311/0x570
> >> [hv_vmbus]
> >> ...
> >>   Vitaly
> >
> > I can't reproduce the panic somehow, but I did find a bug in
> vmbus_process_offer():
> >
> > "hv_event_tasklet_disable(channel) and
> hv_event_tasklet_enable(channel)"
> > are buggy: the 'channel' parameter should be 'newchannel'.
> >
> > This was a copy-and-paste bug... Sorry!
> > Can you fix this and see if the panic will disappear in your side?
> 
> This fixes the issue I'm seeing, thanks!
> 
>   Vitaly

Many thanks, Vitaly!

I'll post v4 shortly.

Thanks,
-- Dexuan