linux-kernel - Re: usbip: vudc: Fix apparent cut-n-paste error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 01 Jun 2016 12:21:06 +0200
From:	Krzysztof Opasiak <k.opasiak@...sung.com>
To:	Dave Jones <davej@...emonkey.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Karol Kosik <karo9@...eria.eu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: usbip: vudc: Fix apparent cut-n-paste error



On 05/31/2016 05:25 PM, Dave Jones wrote:
> Coverity picked up that this looks like a cut-n-paste from an almost
> identical sequence below that didn't get its variable renamed.
> 
> Signed-off-by: Dave Jones <davej@...emonkey.org.uk>
> 
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 8994a13819ab..7091848df6c8 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
>  	if (ud->tcp_socket)
>  		kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
>  
> -	if (ud->tcp_tx) {
> +	if (ud->tcp_rx) {
>  		kthread_stop_put(ud->tcp_rx);
>  		ud->tcp_rx = NULL;
>  	}
> 
> 

Reviewed-by: Krzysztof Opasiak <k.opasiak@...sung.com>

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics