linux-kernel - Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160601104939.GT1743@lahna.fi.intel.com>
Date:	Wed, 1 Jun 2016 13:49:39 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	linux-kernel@...r.kernel.org, Baolin Wang <baolin.wang@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Shuah Khan <shuahkh@....samsung.com>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	Prarit Bhargava <prarit@...hat.com>
Subject: Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday
 error checking

On Tue, May 31, 2016 at 02:32:14PM -0700, John Stultz wrote:
> In commit 86d3473224b0 ("time: Introduce do_sys_settimeofday64()")
> some of the checking for a valid timeval was subtley changed
> which caused -EINVAL to be returned whenever the timeval was null.
> 
> However, it is possible to set the timezone data while specifying
> a NULL timeval, which is usually done to handle systems where the
> RTC keeps local time instead of UTC. Thus the patch causes such
> systems to have the time incorrectly set.
> 
> This patch addresses the issue by handling the error conditionals
> in the same way as was done previously.
> 
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Baolin Wang <baolin.wang@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Shuah Khan <shuahkh@....samsung.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Prarit Bhargava <prarit@...hat.com>
> Reported-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

I can confirm that this patch fixes the issue I'm seeing. Thanks!

Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>