linux-kernel - Re: [PATCH 8/8] Input: ti_am335x_tsc - use variable name for sizeof() operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160601183519.GG4114@dtor-ws>
Date:	Wed, 1 Jun 2016 11:35:19 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	"Andrew F. Davis" <afd@...com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Lee Jones <lee.jones@...aro.org>,
	Dave Gerlach <d-gerlach@...com>, linux-iio@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] Input: ti_am335x_tsc - use variable name for
 sizeof() operator

On Tue, May 31, 2016 at 12:00:13PM -0500, Andrew F. Davis wrote:
> Fix the code formatting to use the kernel preferred style
> of using the actual variables to determize the size using
> the sizeof() operator.
> 
> Signed-off-by: Andrew F. Davis <afd@...com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/ti_am335x_tsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index 8b3f15c..7953381 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -406,7 +406,7 @@ static int titsc_probe(struct platform_device *pdev)
>  	int err;
>  
>  	/* Allocate memory for device */
> -	ts_dev = kzalloc(sizeof(struct titsc), GFP_KERNEL);
> +	ts_dev = kzalloc(sizeof(*ts_dev), GFP_KERNEL);
>  	input_dev = input_allocate_device();
>  	if (!ts_dev || !input_dev) {
>  		dev_err(&pdev->dev, "failed to allocate memory.\n");
> -- 
> 2.8.3
> 

-- 
Dmitry