linux-kernel - Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574F3324.8020904@metafoo.de>
Date:	Wed, 1 Jun 2016 21:10:28 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Alison Schofield <amsfield22@...il.com>, jic23@...nel.org
Cc:	Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing
 frequency

On 06/01/2016 06:35 AM, Alison Schofield wrote:
> Driver was checking for direct mode and trying to lock it, but
> left a gap where mode could change before the desired operation.
> Use iio_device_claim_direct_mode() to guarantee device stays in
> direct mode.
> 
> Refactor function to clarify look-up followed by lock sequence.
> 
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> Cc: Daniel Baluta <daniel.baluta@...il.com>

Looks good, thanks.

Acked-by: Lars-Peter Clausen <lars@...afoo.de>