linux-kernel - Re: [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+TGP_GpuuV+TfmJDJQRPYy3jytGBkLg7Tt1vO31xmk-Q@mail.gmail.com>
Date:	Wed, 1 Jun 2016 16:48:31 -0500
From:	Rob Herring <robh+dt@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Guodong Xu <guodong.xu@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
	Wei Xu <xuwei5@...ilicon.com>
Subject: Re: [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey

On Wed, Jun 1, 2016 at 4:27 PM, John Stultz <john.stultz@...aro.org> wrote:
> From: Guodong Xu <guodong.xu@...aro.org>
>
> Add powerkey entry to the HiKey dts.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Kumar Gala <galak@...eaurora.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
> Cc: Wei Xu <xuwei5@...ilicon.com>
> Cc: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index e92a30c..c8e49a6 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -144,6 +144,13 @@
>                 #interrupt-cells = <2>;
>                 pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>
> +               powerkey:powerkey@b1{

nit: you probably don't need the label and unit-address is not needed, so just:

powerkey {

> +                       compatible = "hisilicon,hi6552-powerkey";
> +                       interrupt-parent = <&pmic>;
> +                       interrupts = <6 0>, <5 0>, <4 0>;
> +                       interrupt-names = "down", "up", "hold 4s";
> +               };
> +
>                 regulators {
>                         ldo2: LDO2 {
>                                 regulator-name = "LDO2_2V8";
> --
> 1.9.1
>