linux-kernel - Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160601185833.GW18670@intel.com>
Date:	Thu, 2 Jun 2016 02:58:33 +0800
From:	Yuyang Du <yuyang.du@...el.com>
To:	Vincent Guittot <vincent.guittot@...aro.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Mike Galbraith <umgwanakikbuti@...il.com>,
	Benjamin Segall <bsegall@...gle.com>,
	Paul Turner <pjt@...gle.com>,
	Morten Rasmussen <morten.rasmussen@....com>,
	Dietmar Eggemann <dietmar.eggemann@....com>
Subject: Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from
 wake_up_new_task() to sched_fork()

On Wed, Jun 01, 2016 at 02:24:29PM +0200, Vincent Guittot wrote:
> On 1 June 2016 at 05:41, Yuyang Du <yuyang.du@...el.com> wrote:
> > Move new task initialization to sched_fork(). For initial non-fair class
> > task, the first switched_to_fair() will do the attach correctly.
> 
> Not sure to catch the explanation. you have only moved and renamed
> init_entity_runnable_average but you speak about initial non-fair
> class

The non-fair class task mentioning is that I stopped a bit to figure
out whether only call sched_fork_fair(), but obviously sched classes
can change, so we should call sched_fork.

And this patch is ammeneable to the previous fix to switched_to().