linux-kernel - Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <574FCFB2.1080607@samsung.com>
Date:	Thu, 02 Jun 2016 08:18:26 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-clk@...r.kernel.org
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem
 to Exynos5410

On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
>> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
>> shared with Exynos5410 and configure the clocks on the latter.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> ---
> 
> [snip]
> 
>>  
>> +&sss {
>> +	clocks = <&clock CLK_SSS>;
>> +	clock-names = "secss";
>> +};
>> +
> 
> [snip]
> 
>>  
>> +&watchdog {
>> +	clocks = <&clock CLK_WDT>;
>> +	clock-names = "watchdog";
>> +	samsung,syscon-phandle = <&pmu_system_controller>;
>> +};
>> +
> 
> Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
> I wonder if the clock and clock-names shouldn't be just defined in the
> shared exynos54xx.dtsi as is the case for the interrupts that are also
> the same?
> 
> The patch looks good to me though, so whatever you decide:
> 
> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Thanks for review and comments.

The 'clock' property cannot be moved - there is no clock phandle and the
clock IDs are not included in 54xx.

Best regards,
Krzysztof