linux-kernel - Re: [PATCH v9 0/2] memory: add Atmel EBI (External Bus Interface) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160602063337.GH4249@piout.net>
Date:	Thu, 2 Jun 2016 08:36:14 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 0/2] memory: add Atmel EBI (External Bus Interface)
 driver

On 23/05/2016 at 09:44:53 +0200, Boris Brezillon wrote :
> Hello,
> 
> This patch series provides support for the EBI bus.
> 
> The EBI (External Bus Interface) is used to access external peripherals
> (NOR, SRAM, NAND, and other specific devices like ethernet controllers).
> Each device is assigned a CS line and an address range and can have its
> own configuration (timings, access mode, bus width, ...).
> This driver provides a generic DT binding to configure a device according
> to its requirements.
> For specific device controllers (like the NAND one) the SMC timings
> should be configured by the controller driver through the matrix and
> smc syscon regmaps.
> 
> Best Regards,
> 
> Boris
> 
> Changes since v8:
> - fixed typo in DT bindings doc
> 
> Changes since v7:
> - move EBI bus config properties directly in the sub-device node
> - prefix all EBI/SMC properties with atmel,smc-
> - rework the driver to take the new binding into account
> - disable the subdevice when EBI implementation fails to configure
>   the bus as requested
> 
> Changes since v6:
> - rework the binding to put per-device config information into a
>   separate subnode and have devices connected to the EBI bus
>   defined as direct children of the EBI node
> - make all EBI timings mandatory
> - keep adding sub-devices when a failure occurs on one of them
> 
> Changes since v5:
> - remove the "atmel,specialized-logic" property: now all devices are
>   are attached to the SMC logic by default, and specialized drivers
>   (like the NAND controller one), should change this configuration
>   manually.
> - provide hardware readout to allow partial config description.
>   This is mainly here to keep existing platforms (where everything
>   is configured by the bootloader/bootstrap) in working state.
> - rename "atmel,tdf-optimized" into "atmel,tdf-mode" and switch from
>   a boolean to string property to properly support partial config
> 
> Changes since v4:
> - fix inconsistencies in SMC and MATRIX registers definition
> - add missing compatible strings for at91sam9rl SoC
> - fix DT bindings documentation
> - replace "atmel,generic-dev" property by "atmel,specialized-logic"
> 
> Changes since v3:
> - added AT91_MATRIX_USBPUCR_PUON definition
> - removed useless macros (those directly returning SoC specific register
>   offsets)
> - use syscon_regmap_lookup_by_phandle instead of of_parse_phandle +
>   syscon_node_to_regmap
> - drop AT91_EBICSA_REGFIELD and AT91_MULTI_EBICSA_REGFIELD macros
> 
> Changes since v2:
> - minor fixes int DT bindings doc
> - fix SMC macros
> - make use of SMC macros defined in include/linux/mfd/syscon/atmel-smc.h
> 
> Changes since v1:
> - almost everything :-)
> 
> Boris Brezillon (2):
>   memory: add Atmel EBI (External Bus Interface) driver
>   memory: atmel-ebi: add DT bindings documentation
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com