linux-kernel - Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160601234111.GA8105@intel.com>
Date:	Thu, 2 Jun 2016 07:41:11 +0800
From:	Yuyang Du <yuyang.du@...el.com>
To:	Vincent Guittot <vincent.guittot@...aro.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Mike Galbraith <umgwanakikbuti@...il.com>,
	Benjamin Segall <bsegall@...gle.com>,
	Paul Turner <pjt@...gle.com>,
	Morten Rasmussen <morten.rasmussen@....com>,
	Dietmar Eggemann <dietmar.eggemann@....com>
Subject: Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task

On Thu, Jun 02, 2016 at 09:29:53AM +0200, Vincent Guittot wrote:
> > My response to your above two comments:
> >
> > As I said, there can be four possibilities going through the above sequences:
> >
> > (1) on_rq, (2) !on_rq, (a) was fair class (representing last_update_time != 0),
> > (b) never was fair class (representing last_update_time == 0, but may not be
> > limited to this)
> >
> > Crossing them, we have (1)(a), (1)(b), (2)(a), and (2)(b).
> >
> > Some will attach twice, which are (1)(b) and (2)(b), the other will attach
> > once, which are (1)(a) and (2)(a). The difficult part is they can be attached
> > at different places.
> 
> ok for (1)(b) but not for (2)(b) and it's far from "attached mostly
> twice every time"

You are right. That claim is reckless, I will change it to:
"sometimes attached twice".