lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 02 Jun 2016 10:11:10 +0200 From: Bjørn Mork <bjorn@...k.no> To: <Mario_Limonciello@...l.com> Cc: <gregkh@...uxfoundation.org>, <hayeswang@...ltek.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>, <pali.rohar@...il.com>, <anthony.wong@...onical.com> Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address <Mario_Limonciello@...l.com> writes: >> > +static u8 amac_ascii_to_hex(int c) >> > +{ >> > + if (c <= 0x39) >> > + return (u8)(c - 0x30); >> > + else if (c <= 0x46) >> > + return (u8)(c - 0x37); >> > + return (u8)(c - 0x57); >> > +} >> > > Sorry forgot to address this. > >> We really don't have such a function somewhere in the kernel already? > > There is a function in acpi/acpica/uthex.c that does this, but it doesn't seem to be used by anything outside of acpica so far. Would it be OK style wise to > #include " ../../acpi/acpica/acutils.h" from r8152.c? Makes me wonder where you looked.... You have hex_to_bin() and hex2bin() in include/linux/kernel.h You could look at usbnet_get_ethernet_addr() for an example of how to do this properly. It's pretty close to this driver in the tree, and should be a natural starting point before reinventing the wheel... Bjørn
Powered by blists - more mailing lists