linux-kernel - Re: [PATCH] i2c: designware: Enable ioctl I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602083330.GY26768@pengutronix.de>
Date:	Thu, 2 Jun 2016 10:33:30 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Weifeng Voon <weifeng.voon@...el.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	jui.nee.tan@...el.com
Subject: Re: [PATCH] i2c: designware: Enable ioctl I2C_TIMEOUT

On Thu, Jun 02, 2016 at 03:57:30PM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.

10ms is only correct with HZ=100. With higher values of HZ you get a
finer resolution. I'd write:

	Respect the transfer timeout set via the I2C_TIMEOUT ioctl.

and not mention the resolution at all. After all your patch doesn't
"enable" that ioctl, just makes use of the value set by it.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |