linux-kernel - Re: ath9k gpio request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 2 Jun 2016 11:01:53 +0200
From:	Janusz Dziedzic <janusz.dziedzic@...to.com>
To:	"Pan, Miaoqing" <miaoqing@....qualcomm.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	ath9k-devel <ath9k-devel@....qualcomm.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ath9k-devel@...ts.ath9k.org" <ath9k-devel@...ts.ath9k.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Miaoqing Pan <miaoqing@...eaurora.org>
Subject: Re: ath9k gpio request

On 2 June 2016 at 10:02, Pan, Miaoqing <miaoqing@....qualcomm.com> wrote:
> Seems there are something wrong in the datasheet,  try
>
> --- a/drivers/net/wireless/ath/ath9k/reg.h
> +++ b/drivers/net/wireless/ath/ath9k/reg.h
> @@ -1122,8 +1122,8 @@ enum {
>  #define AR9300_NUM_GPIO                          16
>  #define AR9330_NUM_GPIO                                 16
>  #define AR9340_NUM_GPIO                                 23
> -#define AR9462_NUM_GPIO                                 10
> -#define AR9485_NUM_GPIO                                 12
> +#define AR9462_NUM_GPIO                                 14
> +#define AR9485_NUM_GPIO                                 11
>  #define AR9531_NUM_GPIO                                 18
>  #define AR9550_NUM_GPIO                                 24
>  #define AR9561_NUM_GPIO                                 23
> @@ -1139,8 +1139,8 @@ enum {
>  #define AR9300_GPIO_MASK                        0x0000F4FF
>  #define AR9330_GPIO_MASK                        0x0000F4FF
>  #define AR9340_GPIO_MASK                        0x0000000F
> -#define AR9462_GPIO_MASK                        0x000003FF
> -#define AR9485_GPIO_MASK                        0x00000FFF
> +#define AR9462_GPIO_MASK                        0x00003FFF
> +#define AR9485_GPIO_MASK                        0x000007FF
>  #define AR9531_GPIO_MASK                        0x0000000F
>  #define AR9550_GPIO_MASK                        0x0000000F
>  #define AR9561_GPIO_MASK                        0x0000000F
>

Thanks, changes in reg.h solve the problem (my card AR9462 rev 01).

BR
Janusz

> Thanks,
> Miaoqing
>
> ________________________________________
> From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Sent: Wednesday, June 1, 2016 8:18 PM
> To: Pan, Miaoqing; Kalle Valo
> Cc: Stephen Rothwell; ath9k-devel; linux-next@...r.kernel.org; linux-kernel@...r.kernel.org; linux-wireless@...r.kernel.org; ath9k-devel@...ts.ath9k.org; netdev@...r.kernel.org; Miaoqing Pan
> Subject: Re: ath9k gpio request
>
> On Wednesday 01 June 2016 04:42 PM, Sudip Mukherjee wrote:
>> On Wednesday 01 June 2016 12:24 PM, Pan, Miaoqing wrote:
>>> which chip ?  And what's the GPIO number ?
>>
>> lspci -v reports:
>> 09:00.0 Network controller: Qualcomm Atheros AR9462 Wireless Network
>> Adapter (rev 01)
>>      Subsystem: Foxconn International, Inc. Device e052
>>      Flags: bus master, fast devsel, latency 0, IRQ 19
>>      Memory at c0500000 (64-bit, non-prefetchable) [size=512K]
>>      Expansion ROM at c0580000 [disabled] [size=64K]
>>      Capabilities: [40] Power Management version 2
>>      Capabilities: [50] MSI: Enable- Count=1/4 Maskable+ 64bit+
>>      Capabilities: [70] Express Endpoint, MSI 00
>>      Capabilities: [100] Advanced Error Reporting
>>      Capabilities: [140] Virtual Channel
>>      Capabilities: [160] Device Serial Number 00-00-00-00-00-00-00-00
>>      Kernel driver in use: ath9k
>>
>> Any easy way to find out the gpio number or i can modify the module to
>> find that out.
>
> Its trying for GPIO 11 with label ath9k-rfkill.
>
> The attached dmesg is with some modification as below.
>
> diff --git a/drivers/net/wireless/ath/ath9k/hw.c
> b/drivers/net/wireless/ath/ath9k/hw.c
> index 8b2895f9..23deea7 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -2729,14 +2729,16 @@ static void ath9k_hw_gpio_cfg_wmac(struct ath_hw
> *ah, u32 gpio, bool out,
>   static void ath9k_hw_gpio_request(struct ath_hw *ah, u32 gpio, bool out,
>                                    const char *label, u32 ah_signal_type)
>   {
> -       WARN_ON(gpio >= ah->caps.num_gpio_pins);
> +//     WARN_ON(gpio >= ah->caps.num_gpio_pins);
> +
> +       pr_err("sudip: %d %s\n", gpio, label);
>
>          if (BIT(gpio) & ah->caps.gpio_mask)
>                  ath9k_hw_gpio_cfg_wmac(ah, gpio, out, ah_signal_type);
>          else if (AR_SREV_SOC(ah))
>                  ath9k_hw_gpio_cfg_soc(ah, gpio, out, label);
> -       else
> -               WARN_ON(1);
> +//     else
> +//             WARN_ON(1);
>   }
>
> Regards
> Sudip
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html