linux-kernel - Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com>
Date:	Thu, 2 Jun 2016 10:15:13 +0100
From:	Harvey Hunt <harvey.hunt@...tec.com>
To:	Purna Chandra Mandal <purna.mandal@...rochip.com>,
	<linux-kernel@...r.kernel.org>
CC:	<linux-mips@...ux-mips.org>, Ralf Baechle <ralf@...ux-mips.org>,
	Joshua Henderson <digitalpeer@...italpeer.com>,
	Joshua Henderson <joshua.henderson@...rochip.com>
Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

Hi Purna,

On 02/06/16 06:20, Purna Chandra Mandal wrote:
> Early clock API pic32_get_pbclk() is defined in early_clk.c and
> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
> set, early_clk.c isn't compiled and so a linker error is reported
> while referring the API from time.c.

Maybe "early_clk.c isn't compiled and so time.c fails to link"?

>
> Fix it by compiling early_clk.c always. Also sort files in
> alphabetical order.
>
> Cc: Harvey Hunt <harvey.hunt@...tec.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: linux-mips@...ux-mips.org
> Cc: Joshua Henderson <digitalpeer@...italpeer.com>
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@...rochip.com>
>
> ---
>
>  arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
> index 4a4c272..c286496 100644
> --- a/arch/mips/pic32/pic32mzda/Makefile
> +++ b/arch/mips/pic32/pic32mzda/Makefile
> @@ -2,8 +2,7 @@
>  # Joshua Henderson, <joshua.henderson@...rochip.com>
>  # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
>  #
> -obj-y			:= init.o time.o config.o
> +obj-y			:= config.o early_clk.o init.o time.o
>
>  obj-$(CONFIG_EARLY_PRINTK)	+= early_console.o      \
> -				   early_pin.o		\
> -				   early_clk.o
> +				   early_pin.o
>

Perhaps add:

Reported-by: Harvey Hunt <harvey.hunt@...tec.com>

Thanks for fixing this,

Reviewed-by: Harvey Hunt <harvey.hunt@...tec.com>

Thanks,

Harvey