linux-kernel - Re: [PATCH -v2 00/33] implement atomic_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jun 2016 09:27:36 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Peter Zijlstra <peterz@...radead.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"will.deacon@....com" <will.deacon@....com>,
	"paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>,
	"waiman.long@....com" <waiman.long@....com>,
	"fweisbec@...il.com" <fweisbec@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"rth@...ddle.net" <rth@...ddle.net>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"egtvedt@...fundet.no" <egtvedt@...fundet.no>,
	"realmz6@...il.com" <realmz6@...il.com>,
	"ysato@...rs.sourceforge.jp" <ysato@...rs.sourceforge.jp>,
	"rkuo@...eaurora.org" <rkuo@...eaurora.org>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
	"james.hogan@...tec.com" <james.hogan@...tec.com>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>,
	"dhowells@...hat.com" <dhowells@...hat.com>,
	"jejb@...isc-linux.org" <jejb@...isc-linux.org>,
	"mpe@...erman.id.au" <mpe@...erman.id.au>,
	"schwidefsky@...ibm.com" <schwidefsky@...ibm.com>,
	"dalias@...c.org" <dalias@...c.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"cmetcalf@...lanox.com" <cmetcalf@...lanox.com>,
	"jcmvbkbc@...il.com" <jcmvbkbc@...il.com>,
	"arnd@...db.de" <arnd@...db.de>, "dbueso@...e.de" <dbueso@...e.de>,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>
Subject: Re: [PATCH -v2 00/33] implement atomic_fetch_$op

On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote:
> Notes:
>  - arc asm/atomic.h is a bit of a mess after the eznps merge, I would
>    recommend a restructure or split of that file, but could not find
>    the will to do it.
>  - arc, metag and tile could convert to _relaxed.

Yes that was bothering me too. The split is indeed in order. However good news is
even w/o it I have decent cleanup as all the backoff retry code can now be
removed. The hardware guys did their foo and production RTL with latest h/w
release doesn't suffer from the scond livelock problem. I'd disabled the config
option for some time and now the code can be removed as well.

What's ur merge plan - are u going to rebase/respin once more so I can push those
updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur tree -
ahead of ur series. I'd much rather prefer the revert / cleanup before adding new
code which extends the back off code only to be deleted later.

What say you ?

-Vineet