linux-kernel - Re: [PATCH] x86: Add early quirk to reset Apple AirPort card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602094842.GF2658@codeblueprint.co.uk>
Date:	Thu, 2 Jun 2016 10:48:42 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Lukas Wunner <lukas@...ner.de>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Chris Milsted <cmilsted@...hat.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Andi Kleen <ak@...ux.intel.com>, Michael Buesch <m@...s.ch>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Konstantin Simanov <k.simanov@...k.ru>,
	Bryan Paradis <bryan.paradis@...il.com>,
	Andrew Worsley <amworsley@...il.com>,
	Chris Bainbridge <chris.bainbridge@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-wireless@...r.kernel.org,
	b43-dev@...ts.infradead.org, zajec5@...il.com
Subject: Re: [PATCH] x86: Add early quirk to reset Apple AirPort card

On Sun, 29 May, at 01:35:28AM, Lukas Wunner wrote:
> The EFI firmware on Macs contains a full-fledged network stack for
> downloading OS X images from osrecovery.apple.com. Unfortunately
> on Macs introduced 2011 and 2012, EFI brings up the Broadcom 4331
> wireless card on every boot and leaves it enabled even after
> ExitBootServices has been called. The card continues to assert its IRQ
> line, causing spurious interrupts if the IRQ is shared. It also corrupts
> memory by DMAing received packets, allowing for remote code execution
> over the air. This only stops when a driver is loaded for the wireless
> card, which may be never if the driver is not installed or blacklisted.

[... Snip a very thorough changelog ...]

This patch looks fine to me from an EFI perspective.

Acked-by: Matt Fleming <matt@...eblueprint.co.uk>