linux-kernel - Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <575006CA.6070705@synopsys.com>
Date:	Thu, 2 Jun 2016 15:43:30 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	David Miller <davem@...emloft.net>, <eladkan@...lanox.com>
CC:	<noamca@...lanox.com>, <linux-kernel@...r.kernel.org>,
	<Alexey.Brodkin@...opsys.com>, <netdev@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi
 reschedule

On Monday 30 May 2016 11:05 AM, David Miller wrote:
> From: Elad Kanfi <eladkan@...lanox.com>
> Date: Thu, 26 May 2016 15:00:06 +0300
> 
>> From: Elad Kanfi <eladkan@...lanox.com>
>>
>> Since NAPI works by shutting down event interrupts when theres
>> work and turning them on when theres none, the net driver must
>> make sure that interrupts are disabled when it reschedules polling.
>> By calling napi_reschedule, the driver switches to polling mode,
>> therefor there should be no interrupt interference.
>> Any received packets will be handled in nps_enet_poll by polling the HW
>> indication of received packet until all packets are handled.
>>
>> Signed-off-by: Elad Kanfi <eladkan@...lanox.com>
>> Acked-by: Noam Camus <noamca@...lanox.com>
> 
> Applied.
> 

ARC osci platform in 4.6 currently have broken networking. This needs a stable
backport to 4.6

Upstream 86651650d16a359e4 ("net: nps_enet: Disable interrupts before napi
reschedule")

Thx,
-Vineet