linux-kernel - Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <057fb9e8-002a-0aac-a36d-ef074ab2111e@osg.samsung.com>
Date:	Thu, 2 Jun 2016 09:27:28 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-clk@...r.kernel.org
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem
 to Exynos5410

Hello Krzysztof,

On 06/02/2016 02:18 AM, Krzysztof Kozlowski wrote:
> On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote:

[snip]

>>>  
>>> +&watchdog {
>>> +	clocks = <&clock CLK_WDT>;
>>> +	clock-names = "watchdog";
>>> +	samsung,syscon-phandle = <&pmu_system_controller>;
>>> +};
>>> +
>>
>> Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
>> I wonder if the clock and clock-names shouldn't be just defined in the
>> shared exynos54xx.dtsi as is the case for the interrupts that are also
>> the same?
>>
>> The patch looks good to me though, so whatever you decide:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> Thanks for review and comments.
> 
> The 'clock' property cannot be moved - there is no clock phandle and the
> clock IDs are not included in 54xx.
>

You are right, I missed that. Thanks a lot for the clarification.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America