linux-kernel - Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602141127.GZ23234@mail.corp.redhat.com>
Date:	Thu, 2 Jun 2016 16:11:27 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Jiri Kosina <jikos@...nel.org>, Bastien Nocera <hadess@...ess.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to
 report multitouch data

On May 31 2016 or thereabouts, Andy Shevchenko wrote:
> On Tue, 2016-05-31 at 18:07 +0200, Benjamin Tissoires wrote:
> > On May 20 2016 or thereabouts, Benjamin Tissoires wrote:
> > > On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > > > On Fri, 2016-05-13 at 19:09 +0300, Andy Shevchenko wrote:
> > > > > On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote:
> > > > > > 
> > > > > > On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > There is no reasons to filter out keyboard and consumer
> > > > > > > > control
> > > > > > > > collections
> > > > > > > > in hid-multitouch.
> > > > > > > > With the previous hid-input fix, there is now a full
> > > > > > > > support of
> > > > > > > > the
> > > > > > > > Type
> > > > > > > > Cover and we can remove all specific bits from hid-core
> > > > > > > > and hid-
> > > > > > > > microsoft.
> > > > > > > > 
> > > > > > > > hid-multitouch will automatically set
> > > > > > > > HID_QUIRK_NO_INIT_REPORTS
> > > > > > > > so
> > > > > > > > we
> > > > > > > > can
> > > > > > > > also remove it from the list of ushbid quirks.
> > > > > > > > 
> > > > > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...h
> > > > > > > > at.com
> > > > > > > > > 
> > > > > > > > ---
> > > > > > > > 
> > > > > > > > Andy, would you mind checking if this series is sufficient
> > > > > > > > to
> > > > > > > > enable
> > > > > > > > the
> > > > > > > > TypeCover of the Surface Book?
> > > > > > > Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.co
> > > > > > > m>
> > > > > > > 
> > > > > > > Noticed little difference that there is no event for the
> > > > > > > device
> > > > > > > anymore,
> > > > > > > just /dev/usb/hiddev0. Would it work properly under X?
> > > > > > Not sure what you mean.
> > > > > > I get 3 input nodes:
> > > > > > Microsoft Surface Type Cover Keyboard
> > > > > > Microsoft Surface Type Cover Consumer Control
> > > > > > Microsoft Surface Type Cover Touchpad
> > > > > > 
> > > > > > Each on this input device is properly assigned an event node
> > > > > > and X
> > > > > > works
> > > > > > with them.
> > > > > > 
> > > > > > If there is no /dev/input/eventX created for your cover, then
> > > > > > this
> > > > > > is
> > > > > > not normal and needs to be investigated.
> > > > > There is no /dev/input/eventX for the touchpad. 
> > > > > It prints that input device is under /usb.../input8, but the
> > > > > actual
> > > > > node
> > > > > I got events from is /dev/usb/hiddev0.
> > > > 
> > > > Correction, it seems the event node is there (event6), but I got
> > > > nothing
> > > > from it
> > > 
> > > Would you mind sending me a hid-recorder[1] trace of the device
> > > while
> > > typing few keys and using the touchpad?
> > 
> > Ping?
> > 
> > Without those logs, I can not do further debugging and Jiri can't take
> > the
> > series...
> 
> Sorry for delay.

No worries.

OK, so it looks like your touchpad stays in the mouse emulation mode for
some reasons. Did you do the recordings with hid-multitouch patched, or
with plain hid-generic or an other one?

After further thoughts, I think it should be acceptable to enable the
mouse collection for Win 8 certified devices. Touchscreens are not
supposed to expose such a mouse emulation, so that would mean that only
touchpad will export one.

I'll come with a patch by the end of the week (hopefully).

Cheers,
Benjamin