linux-kernel - Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLWbJkehr2nPcy-gxHCyYRKT38Jss8COnZ0NK=zDN-fL-A@mail.gmail.com>
Date:	Thu, 2 Jun 2016 10:15:22 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Guodong Xu <guodong.xu@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>, Wei Xu <xuwei5@...ilicon.com>
Subject: Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support

On Wed, Jun 1, 2016 at 8:58 PM, Guodong Xu <guodong.xu@...aro.org> wrote:
> On 2 June 2016 at 01:39, John Stultz <john.stultz@...aro.org> wrote:
>> From: Zhangfei Gao <zhangfei.gao@...aro.org>
>>
>> Add pl031 rtc0 support to hi6220 dtsi
>>
>> Cc: Michael Turquette <mturquette@...libre.com>
>> Cc: Stephen Boyd <sboyd@...eaurora.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Pawel Moll <pawel.moll@....com>
>> Cc: Wei Xu <xuwei5@...ilicon.com>
>> Cc: Guodong Xu <guodong.xu@...aro.org>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>
>> [jstultz: Forward ported and tweaked commit description]
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 189d215..1288995 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -336,6 +336,14 @@
>>                         clock-names = "timer1", "timer2", "apb_pclk";
>>                 };
>>
>> +               rtc0: rtc@...000 {
>> +                       compatible = "arm,pl031", "arm,primecell";
>> +                       reg = <0x0 0xf8003000 0x0 0x1000>;
>> +                       interrupts = <0 12 4>;
>> +                       clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
>> +                       clock-names = "apb_pclk";
>> +               };
>> +
>
> Hi, John
>
> Checked from Hi6220 spec, and verified on HiKey:
>
> +               rtc1: rtc@...04000 {
> +                       compatible = "arm,pl031", "arm,primecell";
> +                       reg = <0x0 0xf8004000 0x0 0x1000>;
> +                       interrupts = <0 8 4>;
> +                       clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> +                       clock-names = "apb_pclk";
> +               };
> +
>
> Would you please append that into the patch?

Sure. I also noticed the node offset for rtc0 doesn't match the
register, so I corrected it as well.

thanks
-john