linux-kernel - Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vb1ra295.fsf@eliezer.anholt.net>
Date:	Thu, 02 Jun 2016 11:12:38 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Arnd Bergmann <arnd@...db.de>, Gerd Hoffmann <kraxel@...hat.com>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list\:MULTIMEDIA CARD \(MMC\)\, SECURE DIGITAL \(SD\) AND..." 
	<linux-mmc@...r.kernel.org>,
	"moderated list\:BROADCOM BCM2835 ARM ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

Arnd Bergmann <arnd@...db.de> writes:

> On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote:
>> +	/* Parse OF address directly to get the physical address for
>> +	 * DMA to our registers.
>> +	 */
>> +	host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0,
>> +						      NULL, NULL));
>
> This looks broken on 64-bit systems when #address-cells=<2>, or if there
> is an intermediate bus with a non-empty ranges property.
>
> What's wrong with platform_get_resource(pdev, IORESOURCE_MEM, 0)?

I'll get to the rest of the review later, but this is a weird pattern
that we have in several bcm2835-related drivers.

We need the address as seen by the DMA controller, not the address from
the ARM's perspective (which is offset by the dma-ranges DT property).
This is the way that people have figured out to get that address.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)