linux-kernel - Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oa7j314j.fsf@eliezer.anholt.net>
Date:	Thu, 02 Jun 2016 11:18:52 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Stefan Wahren <stefan.wahren@...e.com>,
	Gerd Hoffmann <kraxel@...hat.com>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	Mark Rutland <mark.rutland@....com>,
	"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
	Lee Jones <lee@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Stephen Warren <swarren@...dotorg.org>,
	"open list\:MULTIMEDIA CARD MMC\, SECURE DIGITAL SD AND..." 
	<linux-mmc@...r.kernel.org>, Russell King <linux@...linux.org.uk>,
	open list <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	"moderated list\:ARM PORT" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

Stefan Wahren <stefan.wahren@...e.com> writes:

> Hi Gerd,
>
> Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> From: Eric Anholt <eric@...olt.net>
>>
>> With this we can get wifi (brcmfmac) to probe.  Without it we're stuck
>> with timeouts from sdio.c when it tries to set the bus width to 4.
>
> adding a new MMC driver to fix a wifi issue is really weird.
>
> Beside that there are already two MMC drivers (sdhci-bcm2835.c and
> sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
> we add two new ones?

Despite the fact that this is my commit, I don't think it should be
merged.  We should figure out why sdhci-iproc.c isn't working, instead.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)