linux-kernel - Re: [PATCH] of: use pr_fmt prefix for all console printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464898206.9273.2.camel@perches.com>
Date:	Thu, 02 Jun 2016 13:10:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rob Herring <robh@...nel.org>,
	Frank Rowand <frowand.list@...il.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Subject: Re: [PATCH] of: use pr_fmt prefix for all console printing

On Thu, 2016-06-02 at 14:56 -0500, Rob Herring wrote:
> On Thu, Jun 2, 2016 at 12:33 PM, Frank Rowand <frowand.list@...il.com> wrote:
[]
> > > @@ -355,8 +355,6 @@ int of_overlay_create(struct device_node *tree)
> > > 
> > >       id = idr_alloc(&ov_idr, ov, 0, 0, GFP_KERNEL);
> > >       if (id < 0) {
> > > -             pr_err("%s: idr_alloc() failed for tree@%s\n",
> > > -                             __func__, tree->full_name);
> > Every other error in of_overlay_create() results in a pr_err().
> > (The other cases of removing pr_err() in this file are fine, because
> > the errors are already reported in the functions called from this
> > function.)
> > 
> > I would recommend leaving in the pr_err() for idr_alloc() failure.
> I was thinking idr_alloc is going to call kmalloc which will print
> errors on failure, but there may be some case it doesn't.

Only if __GFP_NOWARN is used.
And it's not used in any idr_alloc call.