linux-kernel - Re: [PATCH v2 2/2] ARM: at91: Add DT support for Olimex SAM9-L9260 board.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160602231939.GA32346@rob-hp-laptop>
Date:	Thu, 2 Jun 2016 18:19:39 -0500
From:	Rob Herring <robh@...nel.org>
To:	Raashid Muhammed <raashidmuhammed@...ogic.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: at91: Add DT support for Olimex SAM9-L9260
 board.

On Tue, May 31, 2016 at 12:47:31PM +0530, Raashid Muhammed wrote:
> From: Raashid Muhammed <raashidmuhammed@...ogic.com>
> 
> sam9-l9260 is a low cost board designed by Olimex.
> 
> More information is available at:
> https://www.olimex.com/Products/ARM/Atmel/SAM9-L9260/
> 
> Signed-off-by: Raashid Muhammed <raashidmuhammed@...ogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@...vegnu.org>
> ---
>  Documentation/devicetree/bindings/arm/olimex.txt |   8 +-
>  arch/arm/boot/dts/Makefile                       |   1 +
>  arch/arm/boot/dts/at91-sam9_l9260.dts            | 115 +++++++++++++++++++++++
>  3 files changed, 122 insertions(+), 2 deletions(-)
>  create mode 100644 arch/arm/boot/dts/at91-sam9_l9260.dts

One nit, otherwise:

Acked-by: Rob Herring <robh@...nel.org>

> +			spi0: spi@...c8000 {
> +				cs-gpios = <&pioC 11 0>, <0>, <0>, <0>;
> +				status = "okay";
> +
> +				mtd_dataflash@0 {

flash@0

> +					compatible = "atmel,at45", "atmel,dataflash";
> +					spi-max-frequency = <15000000>;
> +					reg = <0>;
> +				};
> +			};