linux-kernel - RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BCE6BEBCDDF4B84E891D2320CBF96F1D3F9FB1EC@SHSMSX101.ccr.corp.intel.com>
Date:	Fri, 3 Jun 2016 05:46:50 +0000
From:	"Li, Yong B" <yong.b.li@...el.com>
To:	Tony Lindgren <tony@...mide.com>,
	Robert Nelson <robertcnelson@...il.com>
CC:	Benoit Cousson <bcousson@...libre.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	devicetree <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux kernel <linux-kernel@...r.kernel.org>,
	"sdliyong@...il.com" <sdliyong@...il.com>
Subject: RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

Hi Tony,

I can submit a V2 version about the "disabled", or just drop this patch?

Thanks,
Yong
-----Original Message-----
From: Tony Lindgren [mailto:tony@...mide.com] 
Sent: Friday, June 3, 2016 1:57 AM
To: Robert Nelson <robertcnelson@...il.com>
Cc: Li, Yong B <yong.b.li@...el.com>; Benoit Cousson <bcousson@...libre.com>; Rob Herring <robh+dt@...nel.org>; Pawel Moll <pawel.moll@....com>; Mark Rutland <mark.rutland@....com>; Ian Campbell <ijc+devicetree@...lion.org.uk>; Kumar Gala <galak@...eaurora.org>; Russell King <linux@....linux.org.uk>; linux-omap@...r.kernel.org; devicetree <devicetree@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org; linux kernel <linux-kernel@...r.kernel.org>; sdliyong@...il.com
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

* Robert Nelson <robertcnelson@...il.com> [160602 10:48]:
> On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren <tony@...mide.com> wrote:
> >
> > * Robert Nelson <robertcnelson@...il.com> [160602 10:39]:
> > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@...el.com> wrote:
> > >
> > > > From: Yong Li <sdliyong@...il.com>
> > > >
> > > > Without this patch, I2C-1 is missing on beaglebone black boards
> > > >
> > > > Signed-off-by: Yong Li <sdliyong@...il.com>
> > > > ---
> > > >  arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > >
> > >
> > >
> > > This is also 'common' for the white/green, if your really going to 
> > > push this, please add it to:
> > >
> > > am335x-bone-common.dtsi
> >
> > But isn't this exposed on the cape pins? So the use can be whatever 
> > for these pins?
> 
> That is correct, "i2c1" is on the cape connector, with no primary 
> function defined.
> 
> Currently on mainline, the board and cape eeprom i2c bus's are enabled.
> 
> i2c0 = board eeprom
> i2c2 = 'cape' eeprom
> 
> personally, nak by me to add i2c1 by default, should use overlay's to enable it.

Yes sounds like the best we can do is define it but set it with status = "disabled" for now.

Regards,

Tony