linux-kernel - Re: [PATCH 1/3] char: hw_random: Add Amlogic Meson Hardware Random Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160603090758.GA7299@Red>
Date:	Fri, 3 Jun 2016 11:07:58 +0200
From:	LABBE Corentin <clabbe.montjoie@...il.com>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-arm-kernel@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 1/3] char: hw_random: Add Amlogic Meson Hardware Random
 Generator

Hello

I have some minor comments below

> +config HW_RANDOM_MESON
> +	tristate "Amlogic Meson Random Number Generator support"
> +	depends on HW_RANDOM && ARCH_MESON

Perhaps you could change to:
depends on HW_RANDOM
depends on ARCH_MESON || COMPILE_TEST

> +
> +static int meson_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
> +{
> +	struct meson_rng_data *data =
> +			container_of(rng, struct meson_rng_data, rng);
> +
> +	*(u32 *)buf = readl_relaxed(data->base + RNG_DATA);
> +
> +	return sizeof(u32);
> +}

I think you need a test for max < sizeof(u32)

Regards

LABBE Corentin