[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <3rLj4P6Swcz9t6B@ozlabs.org>
Date: Fri, 3 Jun 2016 21:47:01 +1000 (AEST)
From: Michael Ellerman <mpe@...erman.id.au>
To: xinhui <xinhui.pan@...ux.vnet.ibm.com>,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Cc: Andrzej Hajda <a.hajda@...sung.com>,
Christophe Jaillet <christophe.jaillet@...adoo.fr>,
Hari Bathini <hbathini@...ux.vnet.ibm.com>,
Paul Mackerras <paulus@...ba.org>, tglx@...utronix.de,
Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Subject: Re: powerpc/nvram: Fix an incorrect partition merge
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> From: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
>
> When we merge two contiguous partitions whose signatures are marked
> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
> to nvram, not cur's. So lets fix this mistake now.
>
> Also use memset instead of strncpy to set the partition's name. It's
> more readable if we want to fill up with duplicate chars .
Does this ever happen in practice? ie. should we backport the fix to stable
kernels?
Has it always been broken?
cheers
Powered by blists - more mailing lists