linux-kernel - Re: [PATCH] of: irq: fix of_irq_get[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160603120810.GA8472@rob-hp-laptop>
Date:	Fri, 3 Jun 2016 07:08:10 -0500
From:	Rob Herring <robh@...nel.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	grant.likely@...aro.org, devicetree@...r.kernel.org,
	frowand.list@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: irq: fix of_irq_get[_byname]() kernel-doc

On Sat, May 28, 2016 at 11:02:50PM +0300, Sergei Shtylyov wrote:
> The kernel-doc for the of_irq_get[_byname]()  is clearly inadequate in
> describing the return values -- of_irq_get_byname() is documented better
> than of_irq_get() but it  still doesn't mention that 0 is returned iff
> irq_create_of_mapping() fails (it doesn't return an error code in this
> case). Document all possible return value variants, making the writing
> of the word "IRQ" consistent, while at it...
> 
> Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
> Fixes: ad69674e73a1 ("of/irq: do irq resolution in platform_get_irq_byname()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> CC: stable@...r.kernel.org
> 
> ---
> The patch is against Linus' 'linux.git' repo (Grant Likely's repo is outdated).
> 
>  drivers/of/irq.c |   19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

Applied, thanks.

Rob