linux-kernel - Re: [PATCH] of: irq: don't return 0 from of_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160603121432.GB8472@rob-hp-laptop>
Date:	Fri, 3 Jun 2016 07:14:32 -0500
From:	Rob Herring <robh@...nel.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	grant.likely@...aro.org, devicetree@...r.kernel.org,
	frowand.list@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: irq: don't return 0 from of_irq_get()

On Sun, May 29, 2016 at 12:53:08AM +0300, Sergei Shtylyov wrote:
> of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning
> both error code  and 0 on failure is a sign of a misdesigned API. Return
> -ENXIO instead like one of the callers, platform_get_irq(), does; fix up
> the kernel-doc as well...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

So I think this is done this way because of the variation in NO_IRQ 
definition across architectures. But then again, of_irq_get is 
relatively new.

Rob