linux-kernel - Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464958844.1767.50.camel@linux.intel.com>
Date:	Fri, 03 Jun 2016 16:00:44 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Jiri Kosina <jikos@...nel.org>, Bastien Nocera <hadess@...ess.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to
 report multitouch data

On Fri, 2016-06-03 at 14:23 +0200, Benjamin Tissoires wrote:

> On Jun 03 2016 or thereabouts, Andy Shevchenko wrote:
> > On Fri, 2016-06-03 at 11:38 +0200, Benjamin Tissoires wrote:
> > > On Jun 02 2016 or thereabouts, Andy Shevchenko wrote:
> > > > On Thu, 2016-06-02 at 16:11 +0200, Benjamin Tissoires wrote:


> > > > I take linux-next + your two patches from this thread (+ some
> > > > unrelated
> > > > to HID patches).
> > > 
> > > OK. I think I know what happened:
> > > - Microsoft forgot to put the Win 8 certification blob in this
> > >   particular device (of course, because Microsoft)
> > > - we do not detect it as a Win 8 certified and do not set the
> > >   HID_QUIRK_NO_INIT_REPORTS flag
> > > - your dmesg should show some error on plug, and then hid can't
> > > set
> > > the
> > >   input mode
> > > - I can't add a "if win 8 then show the mouse collection" because
> > > your
> > >   device doesn't report itself as win 8 :)
> > > 
> > > Anyway, could you try applying this small diff after my 2 patches
> > > and
> > > report if you now have a working touchpad?:
> > 
> > Nope. There is still no /dev/input/eventX associated with touchpad.
> 
> Weird. On my system, if I replay your logs, I see 4 new nodes:
> /dev/input/event21:	Microsoft Surface Keyboard Keyboard
> /dev/input/event22:	Microsoft Surface Keyboard Consumer Control
> /dev/input/event23:	Microsoft Surface Keyboard Touchpad
> /dev/input/event24:	Microsoft Surface Keyboard Keyboard

I had a line in dmesg that input8 is allocated to Touchpad, but no
eventX (0..6 IIRC) from /dev/input reflects Touchpad events. I can get
them only via /dev/usb/hiddev0.

> 
> Can you attach the dmesg when plugging in the type cover?
> 

I will do later, but there is no such thing 'plugging in'. It's a part
of the notebook, so, I can do detach-attach cycle, though it shouldn't
matter, it should work immediately after boot I suppose.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy