linux-kernel - Re: [PATCH] nvme: lightnvme: make MLC num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5751836F.7060407@bjorling.me>
Date:	Fri, 3 Jun 2016 15:17:35 +0200
From:	Matias Bjørling <m@...rling.me>
To:	Johannes Thumshirn <jthumshirn@...e.de>, Jens Axboe <axboe@...com>
Cc:	Keith Busch <keith.busch@...el.com>,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian

On 06/03/2016 02:44 PM, Johannes Thumshirn wrote:
> According to the OpenChannel SSD interface specification the NAND flash
> MLC page pairing information's number of page page pairings field is the
> first two bytes in the MLC Page Pairing data structure. The hardware's
> data structure itself is little endian so annotate it as such, like the
> rest of lighnvm's data structures.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>   drivers/nvme/host/lightnvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 9461dd6..ea36cbb 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -156,7 +156,7 @@ struct nvme_nvm_completion {
>
>   #define NVME_NVM_LP_MLC_PAIRS 886
>   struct nvme_nvm_lp_mlc {
> -	__u16			num_pairs;
> +	__le16			num_pairs;
>   	__u8			pairs[NVME_NVM_LP_MLC_PAIRS];
>   };
>
>

Thanks Johannes. Applied for 4.8.