linux-kernel - RE: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 19:17:38 +0530
From:	Pramod Kumar <pramod.kumar@...adcom.com>
To:	David Miller <davem@...emloft.net>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	catalin.marinas@....com, will.deacon@....com, kishon@...com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: RE: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

Hi David,

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: 02 June 2016 04:48
> To: pramod.kumar@...adcom.com
> Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com;
> ijc+devicetree@...lion.org.uk; galak@...eaurora.org;
> catalin.marinas@....com; will.deacon@....com; kishon@...com;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
bcm-kernel-
> feedback-list@...adcom.com; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org
> Subject: Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc
SoCs
>
> From: Pramod Kumar <pramod.kumar@...adcom.com>
> Date: Tue, 31 May 2016 19:06:39 +0530
>
> > +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result)
> > +{
> > +	u32 val;
> > +	unsigned int timeout = 1000; /* loop for 1s */
>
> Please order your local variable declarations from longest to shortest
line.
>
> > +static int start_miim_ops(void __iomem *base,
> > +			  u16 phyid, u32 reg, u16 val, u32 op) {
> > +	int ret;
> > +	u32 param;
>
> Likewise.
>
Sure. I'll take care of this in next patch for all places.

> > +static int iproc_mdiomux_read(struct mii_bus *bus, int phyid, int
> > +reg) {
> > +	int ret;
> > +	struct iproc_mdiomux_desc *md = bus->priv;
>
> Likewise.
Sure. I'll take care of this in next patch for all places.

Regards,
Pramod