linux-kernel - Re: [PATCH 2/2] ARM: dts: am335x-bone-common: Mark MAC as having only one PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 19:47:36 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	"Andrew F. Davis" <afd@...com>,
	Benoît Cousson <bcousson@...libre.com>,
	Tony Lindgren <tony@...mide.com>
CC:	<linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: am335x-bone-common: Mark MAC as having only
 one PHY

On 05/27/2016 09:17 PM, Andrew F. Davis wrote:
> Currently am33xx.dtsi declares the MAC controller to have two
> slave ports, on these boards we only use one, so set the slave
> count to one. This eliminates a console error message when
> the non-existent PHY is not detected.
>
> Signed-off-by: Andrew F. Davis <afd@...com>
> ---
>   arch/arm/boot/dts/am335x-bone-common.dtsi | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 0cc150b..8767bbe 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -359,12 +359,8 @@
>   	phy-mode = "mii";
>   };
>
> -&cpsw_emac1 {
> -	phy_id = <&davinci_mdio>, <1>;
> -	phy-mode = "mii";
> -};
> -
>   &mac {
> +	slaves = <1>;
>   	pinctrl-names = "default", "sleep";
>   	pinctrl-0 = <&cpsw_default>;
>   	pinctrl-1 = <&cpsw_sleep>;
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
regards,
-grygorii