linux-kernel - Re: [PATCH 3/3] sched/debug: remove unnecessary CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 16:13:34 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Mel Gorman <mgorman@...hsingularity.net>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] sched/debug: remove unnecessary CONFIG_SCHEDSTATS
 checks

On Fri, Jun 03, 2016 at 03:44:41PM -0500, Josh Poimboeuf wrote:
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3447,7 +3447,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  
>  	update_stats_curr_start(cfs_rq, se);
>  	cfs_rq->curr = se;
> -#ifdef CONFIG_SCHEDSTATS
> +
>  	/*
>  	 * Track our maximum slice length, if the CPU's load is at
>  	 * least twice that of our own weight (i.e. dont track it
> @@ -3457,7 +3457,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  		se->statistics.slice_max = max(se->statistics.slice_max,
>  			se->sum_exec_runtime - se->prev_sum_exec_runtime);
>  	}
> -#endif
> +
>  	se->prev_sum_exec_runtime = se->sum_exec_runtime;

Oops.  This part fails to build without CONFIG_SCHEDSTATS.  This hunk
can just be removed from the patch.

-- 
Josh