linux-kernel - Re: [PATCH] drivers: ssb: Fix comments to suit coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 4 Jun 2016 13:50:10 +0200
From:	Michael Büsch <m@...s.ch>
To:	Hugh Sipière <hgsipiere@...il.com>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: ssb: Fix comments to suit coding style

On Sat,  4 Jun 2016 12:32:13 +0100
Hugh Sipière <hgsipiere@...il.com> wrote:

> I changed it so that these two comments do not end on a line with text.
> 
> Signed-off-by: Hugh Sipière <hgsipiere@...il.com>
> ---
>  drivers/ssb/driver_gpio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c
> index 180e027..f2435f3 100644
> --- a/drivers/ssb/driver_gpio.c
> +++ b/drivers/ssb/driver_gpio.c
> @@ -231,7 +231,8 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus)
>  	chip->ngpio		= 16;
>  	/* There is just one SoC in one device and its GPIO addresses should be
>  	 * deterministic to address them more easily. The other buses could get
> -	 * a random base number. */
> +	 * a random base number.
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_SSB)
>  		chip->base		= 0;
>  	else
> @@ -424,7 +425,8 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
>  	chip->ngpio		= 5;
>  	/* There is just one SoC in one device and its GPIO addresses should be
>  	 * deterministic to address them more easily. The other buses could get
> -	 * a random base number. */
> +	 * a random base number.
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_SSB)
>  		chip->base		= 0;
>  	else


What's the benefit from this change?
Will the next person submit a patch to remove wasted lines that just
contain a */?


-- 
Michael

Content of type "application/pgp-signature" skipped