linux-kernel - Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Jun 2016 09:29:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	George Spelvin <linux@...encehorizons.net>,
	andriy.shevchenko@...ux.intel.com
Cc:	bjorn@...k.no, linux-kernel@...r.kernel.org,
	matt@...eblueprint.co.uk, rv@...musvillemoes.dk,
	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	devel@...ica.org
Subject: Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

(adding acpi folks)

On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote:
> Both input and output code is simplified if we use a mapping from binary
> UUID index to ASCII UUID position.  This lets us combine hyphen-skipping
> and endian-swapping into one table.
> 
> This significantly simplifies __uuid_to_bin(), which was using *two*
> lookup tables.

Seems sensible, thanks.

Trivially, acpi defines this but doesn't seem to use it.

include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /* Total length of a UUID string */

And Ingo commented last month:
https://lkml.org/lkml/2016/4/29/69

Maybe this __uuid_to_bin function should be made public and
the acpi version in drivers/acpi/acpica/utuuid.c should be
removed.